Raj: I’m glad it’s being used in products out in the field. By the way, you did sign that damage waiver before shipping, right?

I used your code for a project I was working on and it has turned out great. One thing that I found out though is that your latest release (0.4.1) will not work on 64-bit machines. The problem is that you are using floats instead of CGFloat. This is mostly not an issue since it’ll get cast to the correct value, but since you are then using NSInvocation which sets arguments via addresses to memory, it gets a bit messy. The margin was not showing up when compiled as 64-bit. Once I changed the floats to CGFloats everything started working.

1) physicalLineAtInsertion: returns the physical line in the text document where the insertion point is positioned in the textView.

2) logicalLineAtInsertion: returns the logical line in the textView where the insertion point is positioned in the text view

3) indexOfPhysicalLine: returns the character index of line corresponding to line number.

4) logicalLineIndexAtPhysicalCharacterIndex: returns the index of the wrapped line of text in the text view corresponding to the physical line index obtained from 3.

5) gotoLine: uses 3 & 4 to position the insertion point in the text view at the beginning of

There may be a more optimal way of doing things, but these work on small texts nicely…

Thank you for your line number contribution….

Bruce

Code:
———————————————————–
-(unsigned) logicalLineAtInsertion
{
NSTextView* tview = [self clientView];
NSLayoutManager *layoutManager = [tview layoutManager];
NSRange lineRange;
unsigned numberOfLines, index, numberOfGlyphs = NSMaxRange([layoutManager glyphRangeForCharacterRange:NSMakeRange(0,[tview selectedRange].location) actualCharacterRange:NULL]);
for (numberOfLines = 0, index = 0; index < numberOfGlyphs; numberOfLines++){
(void) [layoutManager lineFragmentRectForGlyphAtIndex:index
effectiveRange:&lineRange];
index = NSMaxRange(lineRange);
}

return numberOfLines;

}

-(unsigned) physicalLineAtInsertion
{
NSTextView* tview = [self clientView];
unsigned physical = [self lineNumberForCharacterIndex:[tview selectedRange].location inText:[tview string]] + 1;
return physical;

}

-(unsigned) indexOfPhysicalLine:(unsigned) linenumber
{

if (linenumber == 1) return 0;
NSString *string = [[self clientView] string];
unsigned numberOfLines, index, stringLength = [string length];
for (index = 0, numberOfLines = 0; index < stringLength; numberOfLines++)
{
index = NSMaxRange([string lineRangeForRange:NSMakeRange(index, 0)]);
if (numberOfLines == linenumber- 2) break;
}

return index;

}

-(unsigned) logicalLineIndexAtPhysicalCharacterIndex:(unsigned) physicalindex
{
NSTextView* tview = [self clientView];
NSLayoutManager *layoutManager = [tview layoutManager];
NSRange lineRange;
unsigned numberOfLines, index, numberOfGlyphs = NSMaxRange([layoutManager glyphRangeForCharacterRange:NSMakeRange(0,physicalindex) actualCharacterRange:NULL]);
for (numberOfLines = 0, index = 0; index < numberOfGlyphs; numberOfLines++){
(void) [layoutManager lineFragmentRectForGlyphAtIndex:index
effectiveRange:&lineRange];
index = NSMaxRange(lineRange);
}

return index;

}

-(void) gotoLine:(unsigned) lineNumber
{

NSTextView* tview = [self clientView];
unsigned insertionLocation = [self logicalLineIndexAtPhysicalCharacterIndex:[self indexOfPhysicalLine:lineNumber]];
[tview setSelectedRange:NSMakeRange(insertionLocation,0)];
[tview scrollRangeToVisible:NSMakeRange(insertionLocation,0)];
}

One thing I did notice is that calculation of the line number from the mouse coordinates could be quicker as it does seem a bit pokey with huge files. But other than that, I’m not seeing any misplaced markers.

Jonathan: I changed the default font used. The misalignment is a font metrics issue but it seems that using Lucida Grande makes for better alignment and is what XCode uses.